test: fix Session tests execution in random order#10370
Open
gr8man wants to merge 3 commits into
Open
Conversation
michalsn
reviewed
Jul 8, 2026
michalsn
left a comment
michalsn
left a comment
Member
There was a problem hiding this comment.
The code change itself looks fine, but the PR description and title should be corrected.
Moving the skip earlier avoids unnecessary DB setup... however, the claim that tearDown() is never executed is inaccurate, and tearDownDatabase() is not responsible for rolling back migrations anyway. So this is more of a cleanup/refactor that prevents unnecessary database initialization for skipped tests, rather than a fix for missing teardown cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref: #9968
This PR moves the
markTestSkippedlogic earlier in the setup phase for session tests. By checking the skip conditions before the database is initialized, we avoid unnecessary setup operations and improve test execution speed.Checklist: